test(assets-controller): add stale-balance scenario integration tests for accounts API v6 - #10584

…-balance suite

Follow the shared-utils schema of the other AssetsController integration
suites: `getIgnoringCase` moves to `__fixtures__/test-utils.ts` instead of
a per-suite copy, and the account builders in
`__fixtures__/stale-balance/staleBalanceWallet.ts` delegate to the shared
`createMockInternalAccount` (as `AssetsController.spam-cleanup.integration
test.ts` does) rather than hand-rolling `InternalAccount` boilerplate.

…teSurface assertion utils

- The Multicall3 `aggregate3` fixture no longer prefixes a `blockNumber`
  `uint256` before the results array: the real contract returns `Result[]`
  only (only `aggregate`/`tryAggregate` return a block number), so the
  batched read path now decodes instead of silently falling back to
  single `balanceOf` calls (review finding).
- Amount assertions now go through `StateSurface`-style utils
  (`buildBalancesSurface` + per-account `SOLANA_BALANCES`/`BSC_BALANCES`/
  `MAINNET_BALANCES`), matching the other AssetsController integration
  suites.

…cenario describe

Adopt the exact `StateSurface` pattern of the bsc-spam integration
suite: a bare `type StateSurface` and a `const BALANCES: StateSurface`
whose lookUp binds the account's balances record — copied verbatim into
each scenario describe (the wallet spans three accounts, so each
describe binds its own), replacing the `buildBalancesSurface` factory.

…fix, and verbatim StateSurface utils

The three commits below (d3c9d4f, 48b3abd, 1c100ff) landed
empty — their changes were never staged before the plumbing commit, so
only the SHAs moved. This commit actually lands their changes:

- Reuse the shared integration-test utils: consolidate `getIgnoringCase`
  into `__fixtures__/test-utils.ts` and delegate the account builders in
  `staleBalanceWallet.ts` to the shared `createMockInternalAccount`.
- Fix the Multicall3 `aggregate3` fixture's wire shape: drop the
  `blockNumber` `uint256` prefix — the real contract returns `Result[]`
  only, so the batched read path decodes instead of silently falling
  back to single `balanceOf` calls.
- Copy the bsc-spam suite's `StateSurface` utils verbatim: bare
  `type StateSurface` and a `const BALANCES: StateSurface` per scenario
  describe (this wallet spans three accounts), with all amount
  assertions reading `surface.lookUp`.

Assert with the bsc-spam-token exemplar dialect (direct
BALANCES.lookUp(...).toMatchObject, inline key-set checks) instead of the
invented expectAmount/expectedAmount/lowerKeySet helpers; carry-over states
inline via buildEmptyStaleBalanceState. Drop all banner separators and
rationale comments from the suite and the __fixtures__/stale-balance helpers,
keeping one-to-two-line summaries only; remove the dead
USDT_ASSET_ID_LOWERCASE constant.

…e-this-sp0

# Conflicts:
#	packages/assets-controller/src/__fixtures__/test-utils.ts

Per review: add getAssetIds and lookupAmount to each describe's BALANCES
surface so the repeated lower-cased key-set checks and amount assertions
read expect(BALANCES.getAssetIds(state)).toStrictEqual(...) and
expect(BALANCES.lookupAmount(state, assetId)).toBe(...) across every
scenario. Drop the scenario-3 key-set check (redundant with its balance
assertions) and replace scenario-11's with a direct USDC amount
assertion; S5/S8/S9/S10 key-sets now compare surfaces of captured states.

…r-stale-balance-scenarios

Main added a lint:tsc:check job that compares repo-wide tsc errors
against tsc-suppressions.json. The stale-balance suite files carry
pre-existing latent test-file type errors that no CI job previously
checked, so the new gate fails without suppressions. Merge main to pick
up the tooling and record the 14 errors across the 5 suite files with
the repo's own lint:tsc:check --suppress-all script.

…f suppressing

Rather than adding the suite's 14 latent test-file type errors to
tsc-suppressions.json, fix them in place:

- Give V6BalanceEntry a structural type so the bsc-derived literal type
  stops rejecting mainnet rows, balance-replacement spreads, and the
  zero-balance stub.
- Annotate mockStaleBalanceApis's options with the shared
  StaleBalanceApiMutations type; they were inferred as never[]/{}.
- Complete the account metadata in the wallet builders with keyring
  and importTime defaults, mirroring createMockInternalAccount.
- Complete the transactionConfirmed payload's TransactionMeta fields
  (id, networkClientId, status, time).
- Cast defaultAbiCoder.encode's result to Hex; it always returns hex.

Keep @ts-expect-error only for the deliberately malformed balance
rows and Hoodi's zero-address ERC-20 native-asset fallback, which the
extension itself uses for chains missing from the slip44 map.

Drop the tsc-suppressions.json entries added in 8bef618.